Skip to content

Added Dijkstra era #5030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added Dijkstra era #5030

wants to merge 3 commits into from

Conversation

Soupstraw
Copy link
Contributor

@Soupstraw Soupstraw commented May 8, 2025

Description

This PR sets up a subproject for the new Dijkstra era

I removed unnecessary era parametrization from GovActionId to make translations easier.

close #4955

Checklist

  • Commits in meaningful sequence and with useful messages.
  • Tests added or updated when needed.
  • CHANGELOG.md files updated for packages with externally visible changes.
    NOTE: New section is never added with the code changes. (See RELEASING.md).
  • Versions updated in .cabal and CHANGELOG.md files when necessary, according to the
    versioning process.
  • Version bounds in .cabal files updated when necessary.
    NOTE: If bounds change in a cabal file, that package itself must have a version increase. (See RELEASING.md).
  • Code formatted (use scripts/fourmolize.sh).
  • Cabal files formatted (use scripts/cabal-format.sh).
  • CDDL files are up to date (use scripts/gen-cddl.sh)
  • hie.yaml updated (use scripts/gen-hie.sh).
  • Self-reviewed the diff.

@Soupstraw Soupstraw force-pushed the jj/dijkstra-certs branch from cb80f34 to 688f2ba Compare May 8, 2025 12:52
@Soupstraw Soupstraw marked this pull request as ready for review May 8, 2025 13:17
@Soupstraw Soupstraw requested a review from a team as a code owner May 8, 2025 13:17
Copy link
Collaborator

@lehins lehins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is not what I had in mind when I created a ticket.

We need an era that is equivalent to Conway, not just a placeholder package.

In other words it should reuse all of the types and rules and should be running all of the reusable tests from previous eras, including impspec

@lehins
Copy link
Collaborator

lehins commented May 9, 2025

@Soupstraw While performing this task I would like for you to also write up a document that explains the steps that are necessary to follow in order to define a new blank era that matches the behavior of the previous one exactly and executes all of the same tests.

@Soupstraw Soupstraw marked this pull request as draft May 13, 2025 15:59
@Soupstraw Soupstraw force-pushed the jj/dijkstra-certs branch 3 times, most recently from a1f79ae to 653e068 Compare May 20, 2025 16:59
@Soupstraw Soupstraw marked this pull request as ready for review May 20, 2025 16:59
@Soupstraw Soupstraw force-pushed the jj/dijkstra-certs branch 3 times, most recently from 8ad56f1 to e6687a0 Compare May 20, 2025 17:02
@Soupstraw Soupstraw requested a review from lehins May 20, 2025 17:06
@Soupstraw Soupstraw force-pushed the jj/dijkstra-certs branch 2 times, most recently from 0ad9a04 to 1b87737 Compare May 20, 2025 17:10
@Soupstraw Soupstraw marked this pull request as draft May 21, 2025 10:10
@Soupstraw Soupstraw force-pushed the jj/dijkstra-certs branch 3 times, most recently from ca870e4 to 93ed7dd Compare May 21, 2025 12:54
@Soupstraw Soupstraw marked this pull request as ready for review May 21, 2025 12:54
@Soupstraw Soupstraw force-pushed the jj/dijkstra-certs branch 3 times, most recently from 4caf869 to 4f84150 Compare May 22, 2025 10:34
@Soupstraw Soupstraw force-pushed the jj/dijkstra-certs branch from 4f84150 to f76852a Compare May 22, 2025 10:39
@Soupstraw Soupstraw force-pushed the jj/dijkstra-certs branch from f76852a to 0a1be72 Compare May 22, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create new era named Dijkstra
2 participants